Re: [PATCH RESEND] stm class: Remove unnecessary local variable in stm_write
From: Thorsten Blum
Date: Mon Jan 26 2026 - 02:59:27 EST
On 26. Jan 2026, at 07:33, Alexander Shishkin wrote:
> Thorsten Blum <thorsten.blum@xxxxxxxxx> writes:
>
>> The local variable 'err' and the corresponding if check in stm_write()
>> are unnecessary. Remove them.
>
> Nice catch! Is this a result of manual code inspection or were any tools
> used, an AI agent or a coccinelle script or whatnot?
Manual code inspection. I think I stumbled upon it when I was working on
https://lore.kernel.org/lkml/20250909102512.694203-2-thorsten.blum@xxxxxxxxx/
https://lore.kernel.org/lkml/20250909102512.694203-4-thorsten.blum@xxxxxxxxx/
which are also still pending. Could you take a look at all three patches
while you're at it?
Thanks,
Thorsten