Re: [PATCH v2 4/5] rust: io: add `register!` macro
From: Alexandre Courbot
Date: Mon Jan 26 2026 - 06:50:25 EST
On Mon Jan 26, 2026 at 4:45 PM JST, Alexandre Courbot wrote:
> I also only noticed now the proposed reordering:
>
> minor_version: [3:0],
>
> I don't have a strong opinion on that, but fwiw SystemRDL seems to do
> something like
>
> field minor_version[3:0];
>
> If we agree to align on it the latter might be preferable?
I have tried implementing the alternative syntaxes, and I think this is
a case where the original one was more readable. The bit fields are
better aligned and easier to skim when they are put before the field
name.
I'll keep it for v3, but of course remain open to alternatives.