Re: [PATCH RFC 2/3] rust: tty: add TTY subsystem abstractions

[하승종]

2026년 1월 26일 (월) PM 9:55, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>님이 작성:
>
> On Mon, Jan 26, 2026 at 12:22:09PM +0000, SeungJong Ha via B4 Relay wrote:
> > +/// Major device number for TTY aux devices.
> > +pub const TTYAUX_MAJOR: i32 = bindings::TTYAUX_MAJOR as i32;
>
> This does not belong in the rust bindings as something to export, sorry.
> I see you wanting to use it in your example driver, but if you do need
> it elsewhere, just declare and use it there, the rust layer should not
> be the one exporting it.
>

You are right. TTYAUX_MAJOR should be defined locally in the driver.

> You also are exporting lots of other stuff with these bindings that are
> not needed or used.  Are you sure that's the right thing to do?
>
> thanks,
>
> greg k-h

I also agree that I should have restricted exports to only what is
currently used.

Thanks,

SeungJong Ha