Re: [PATCH] arm64: dts: qcom: talos: Add missing clock-names to GCC

From: Dmitry Baryshkov

Date: Mon Jan 26 2026 - 08:33:44 EST


On Mon, Jan 26, 2026 at 10:45:03AM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> The binding for this clock controller requires that clock-names are
> present. They're not really used by the kernel driver, but they're
> marked as required, so someone might have assumed it's done on purpose
> (where in reality we try to stay away from that since index-based
> references are faster, take up less space and are already widely used)
> and referenced it in drivers for another OS.
>
> Hence, do the least painful thing and add the missing entries.

One (me included) would assume that the presense of clock-names imples
that the clocks are fetched according to those names and become very
surprised if they are not. As such I'd suggest fixing the bindings instead.

>
> Fixes: 8e266654a2fe ("arm64: dts: qcom: add QCS615 platform")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/talos.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>

--
With best wishes
Dmitry