Re: [PATCH v8 9/9] vfio: Remove the pcie check for VFIO_PCI_ERR_IRQ_INDEX

From: Farhan Ali

Date: Mon Jan 26 2026 - 12:38:29 EST


On 1/26/2026 7:31 AM, Julian Ruess wrote:
On Thu Jan 22, 2026 at 8:44 PM CET, Farhan Ali wrote:
We are configuring the error signaling on the vast majority of devices and
it's extremely rare that it fires anyway. This allows userspace to be
notified on errors for legacy PCI devices. The Internal Shared Memory (ISM)
device on s390x is one such device. For PCI devices on IBM s390x error
recovery involves platform firmware and notification to operating system
is done by architecture specific way. So the ISM device can still be
recovered when notified of an error.

Signed-off-by: Farhan Ali <alifm@xxxxxxxxxxxxx>
---
drivers/vfio/pci/vfio_pci_core.c | 8 ++------
drivers/vfio/pci/vfio_pci_intrs.c | 3 +--
2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
index c92c6c512b24..9d44df9e21db 100644
--- a/drivers/vfio/pci/vfio_pci_core.c
+++ b/drivers/vfio/pci/vfio_pci_core.c
@@ -778,8 +778,7 @@ static int vfio_pci_get_irq_count(struct vfio_pci_core_device *vdev, int irq_typ
return (flags & PCI_MSIX_FLAGS_QSIZE) + 1;
}
} else if (irq_type == VFIO_PCI_ERR_IRQ_INDEX) {
- if (pci_is_pcie(vdev->pdev))
I'm wondering why this pci_is_pcie was introduced here in the first place.

Do you have any ideas?

We actually don't know why it was originally added. The change was added with the commit dad9f89 "VFIO-AER:Vfio-pci driver changes for supporting AER".

But after discussion on it with Alex, we decided to remove the check (https://lore.kernel.org/all/ffc2fc08-2e95-4b35-840c-be8f5511340f@xxxxxxxxxxxxx/)

Thanks

Farhan

-- snip --