Re: [PATCH rdma-next] RDMA/core: release devices_rwsem when calling device_del

From: Sharath Srinivasan

Date: Mon Jan 26 2026 - 13:48:35 EST


On 2026-01-25 5:47 a.m., Leon Romanovsky wrote:
> On Mon, Jan 19, 2026 at 03:53:29PM -0400, Jason Gunthorpe wrote:
>> On Mon, Jan 19, 2026 at 11:43:52AM -0800, Sharath Srinivasan wrote:
>>> The sync strategy in remove_all_compat_devs() can improved
>>> by adopting that of rdma_dev_exit_net() which releases devices_rwsem
>>> before calling remove_one_compat_dev()/device_del().
>>>
>>> Also fixes a comment typo in rdma_dev_exit_net().
>>
>> You cannot change this locking without writing a huge commit message
>> explaining in detail the reason why any change like this is safe..
>
> We can drop this patch, it doesn't even apply.
>
> Thanks
>

Thanks for trying. I'll send a rebased-v2 with an expanded commit message as Jason suggested.

Regards,
Sharath

>>
>> Jason
>>
>