Re: [PATCH] xfs: fix spacing style issues in xfs_alloc.c
From: Darrick J. Wong
Date: Mon Jan 26 2026 - 14:45:54 EST
On Sat, Jan 24, 2026 at 12:04:32AM +0900, Shin Seong-jun wrote:
> Fix checkpatch.pl errors regarding missing spaces around assignment
> operators in xfs_alloc_compute_diff() and xfs_alloc_fixup_trees().
>
> Adhere to the Linux kernel coding style by ensuring spaces are placed
> around the assignment operator '='.
>
> Signed-off-by: Shin Seong-jun <shinsj4653@xxxxxxxxx>
Reviewed-by: "Darrick J. Wong" <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/libxfs/xfs_alloc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index ad381c73abc4..c64e6c13f70d 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -376,8 +376,8 @@ xfs_alloc_compute_diff(
> xfs_agblock_t freeend; /* end of freespace extent */
> xfs_agblock_t newbno1; /* return block number */
> xfs_agblock_t newbno2; /* other new block number */
> - xfs_extlen_t newlen1=0; /* length with newbno1 */
> - xfs_extlen_t newlen2=0; /* length with newbno2 */
> + xfs_extlen_t newlen1 = 0; /* length with newbno1 */
> + xfs_extlen_t newlen2 = 0; /* length with newbno2 */
> xfs_agblock_t wantend; /* end of target extent */
> bool userdata = datatype & XFS_ALLOC_USERDATA;
>
> @@ -577,8 +577,8 @@ xfs_alloc_fixup_trees(
> int i; /* operation results */
> xfs_agblock_t nfbno1; /* first new free startblock */
> xfs_agblock_t nfbno2; /* second new free startblock */
> - xfs_extlen_t nflen1=0; /* first new free length */
> - xfs_extlen_t nflen2=0; /* second new free length */
> + xfs_extlen_t nflen1 = 0; /* first new free length */
> + xfs_extlen_t nflen2 = 0; /* second new free length */
> struct xfs_mount *mp;
> bool fixup_longest = false;
>
> --
> 2.47.3
>
>