Re: [PATCH v1 0/3] perf more ELF machine usage
From: Arnaldo Carvalho de Melo
Date: Mon Jan 26 2026 - 15:57:29 EST
On Fri, Jan 23, 2026 at 04:16:08PM -0800, Ian Rogers wrote:
> Switch 3 more cases where the perf_env arch was being used to
> determine the architecture type and switch to using the ELF
> machine. This includes the addition of minimal instruction parsing in
> perf script for architectures other than x86, or x86 when
> cross-platform.
>
> Note: this series will conflict with the e_flags series:
> https://lore.kernel.org/lkml/20260123222209.1181249-1-irogers@xxxxxxxxxx/
> that adds an additional out argument to thread__e_machine. In all the
> cases here that argument should be NULL. So:
> thread__e_machine(thread, machine)
> becomes:
> thread__e_machine(thread, machine, /*e_flags=*/NULL)
This one isn't applying.
- Arnaldo
> Ian Rogers (3):
> perf script: Fix script_fetch_insn for more than just x86
> perf callchain: Switch callchain_param_setup from an arch to an
> e_machine
> perf thread-stack: Switch thread_stack__init to use e_machine
>
> tools/perf/arch/x86/util/Build | 1 -
> tools/perf/arch/x86/util/archinsn.c | 27 -------
> tools/perf/builtin-report.c | 6 +-
> tools/perf/builtin-script.c | 20 +-----
> .../scripts/python/Perf-Trace-Util/Context.c | 2 +-
> tools/perf/tests/dlfilter-test.c | 1 -
> tools/perf/util/archinsn.h | 12 ----
> tools/perf/util/callchain.c | 5 +-
> tools/perf/util/callchain.h | 2 +-
> tools/perf/util/dlfilter.c | 3 +-
> tools/perf/util/sample.c | 71 +++++++++++++++++++
> tools/perf/util/sample.h | 7 ++
> tools/perf/util/thread-stack.c | 4 +-
> tools/perf/util/trace-event-scripting.c | 16 -----
> tools/perf/util/trace-event.h | 3 -
> 15 files changed, 91 insertions(+), 89 deletions(-)
> delete mode 100644 tools/perf/arch/x86/util/archinsn.c
> delete mode 100644 tools/perf/util/archinsn.h
>
> --
> 2.52.0.457.g6b5491de43-goog
>