Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds
From: Samuel Thibault
Date: Mon Jan 26 2026 - 16:56:31 EST
Henry Zhang, le lun. 26 janv. 2026 15:17:07 -0500, a ecrit:
> The documentation had a TODO questioning whether the unit was in
> jiffies. The implementation in drivers/accessibility/speakup/main.c
> passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> in milliseconds.
>
> Signed-off-by: Henry Zhang <zeri@xxxxxxxxx>
Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Thanks!
> ---
> Documentation/ABI/stable/sysfs-driver-speakup | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup
> index bcb6831aa114..8b508b4a7a00 100644
> --- a/Documentation/ABI/stable/sysfs-driver-speakup
> +++ b/Documentation/ABI/stable/sysfs-driver-speakup
> @@ -23,8 +23,7 @@ What: /sys/accessibility/speakup/bleep_time
> KernelVersion: 2.6
> Contact: speakup@xxxxxxxxxxxxxxxxx
> Description: This controls the duration of the PC speaker beeps speakup
> - produces.
> - TODO: What are the units? Jiffies?
> + produces, in milliseconds.
>
> What: /sys/accessibility/speakup/cursor_time
> KernelVersion: 2.6
> --
> 2.34.1
>