RE: [Intel-wired-lan] [PATCH v2] i40e: drop useless bitmap_weight() call in i40e_set_rxfh_fields()
From: Rinitha, SX
Date: Tue Jan 27 2026 - 01:23:24 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Yury Norov (NVIDIA)
> Sent: 18 December 2025 07:28
> To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw <przemyslaw.kitszel@xxxxxxxxx>; Andrew Lunn <andrew+netdev@xxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Yury Norov (NVIDIA) <yury.norov@xxxxxxxxx>; Loktionov, Aleksandr <aleksandr.loktionov@xxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH v2] i40e: drop useless bitmap_weight() call in i40e_set_rxfh_fields()
>
> bitmap_weight() is O(N) and useless here, because the following
> for_each_set_bit() returns immediately in case of empty flow_pctypes.
>
> Signed-off-by: Yury Norov (NVIDIA) <yury.norov@xxxxxxxxx>
> ---
> v1: https://lore.kernel.org/all/20251216002852.334561-1-yury.norov@xxxxxxxxx/
> v2: don't drop flow_id (Aleksandr).
>
> .../net/ethernet/intel/i40e/i40e_ethtool.c | 21 +++++++------------
> 1 file changed, 8 insertions(+), 13 deletions(-)
>
Tested-by: Rinitha S <sx.rinitha@xxxxxxxxx> (A Contingent worker at Intel)