Re: [net-next PatchV4 2/2] Octeontx2-pf: Add support for DMAC_FILTER trap

[Hariprasad Kelam]

On 2026-01-26 at 03:54:12, Jakub Kicinski (kuba@xxxxxxxxxx) wrote:
> On Fri, 23 Jan 2026 16:17:31 +0530 Hariprasad Kelam wrote:
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> > @@ -3282,6 +3282,10 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >  	if (err)
> >  		goto err_mcam_flow_del;
> >  
> > +	err = otx2_devlink_traps_register(pf);
> > +	if (err)
> > +		goto err_unregister_dl;
> > +
> >  	/* Initialize SR-IOV resources */
> >  	err = otx2_sriov_vfcfg_init(pf);
> >  	if (err)
> > @@ -3314,6 +3318,8 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> >  	otx2_sriov_vfcfg_cleanup(pf);
> >  err_pf_sriov_init:
> >  	otx2_shutdown_tc(pf);
> > +err_unregister_dl:
> > +	otx2_unregister_dl(pf);
> 
> Hm, you're still not calling otx2_devlink_traps_unregister()
> anywhere in this unwind ladder. If the missing otx2_unregister_dl()
> is a pre-existing bug please send a separate fix (to net?) to address
> that, and then this series on top.
>
  ACK, will send "otx2_unregister_dl" as a separate patch.
> >  err_mcam_flow_del:
> >  	otx2_mcam_flow_del(pf);
> >  err_unreg_netdev:
> > @@ -3514,6 +3520,7 @@ static void otx2_remove(struct pci_dev *pdev)
> >  	/* Disable link notifications */
> >  	otx2_cgx_config_linkevents(pf, false);
> >  
> > +	otx2_devlink_traps_unregister(pf);
> >  	otx2_unregister_dl(pf);
> -- 
> pw-bot: cr
>