Re: [PATCH v7 3/7] media: platform: amd: Add isp4 fw and hw interface

[Du, Bin]

Hi Sakari, apologies for any inconvenience this may cause. Would you 
please confirm the following remaining one item in the patch at your 
earliest convenience, so that we can ensure its inclusion in version 8?

On 1/20/2026 5:22 PM, Du, Bin wrote:
> Hi Sakari, there's still one left. Could you please help check it?
>
> On 1/7/2026 4:44 PM, Du, Bin wrote:
> > Thank you, Sakari for the feedback.
> >
> > On 12/22/2025 5:37 PM, Sakari Ailus wrote:
> > > Hi Bin,
> > >
> > > On Tue, Dec 16, 2025 at 05:13:22PM +0800, Bin Du wrote:
>
> [snip]
>
> > > > +enum isp4fw_buffer_source {
> > > > +    /* The buffer is from the stream buffer queue */
> > > > +    BUFFER_SOURCE_STREAM,
> > > > +};
> > >
> > > Could you also use the ISP4 (or ISP4IF) prefix for these, please? 
> > > Many look
> > > rather generic.
> >
> > Thank you for highlighting this matter, since these definitions are 
> > located in isp4_fw_cmd_resp.h, ISP4_FW may be a more appropriate 
> > prefix. Just to confirm: are you suggesting that we should add this 
> > prefix to all macros and enums? For example, changing 
> > CMD_ID_SET_STREAM_CONFIG to ISP4_FW_CMD_ID_SET_STREAM_CONFIG, and 
> > BUFFER_SOURCE_STREAM to ISP4_FW _BUFFER_SOURCE_STREAM? Our initial 
> > thought was that these would only be used within ISP and shouldn't 
> > lead to any confusion.
>
> Hi Sakari, would you please help to confirm so we can decide if further 
> modification is needed.
>
> [snip]

--
Regards,
Bin