Re: [PATCH] gpiolib: acpi: use BIT_ULL() for u64 mask in address space handler

[Bartosz Golaszewski]

On Tue, Jan 27, 2026 at 9:08 AM Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Jan 26, 2026 at 06:59:14AM +0300, Denis Sergeev wrote:
> > The BIT() macro uses unsigned long, which is 32 bits on 32-bit
> > architectures. When iterating over GPIO pins with index >= 32,
> > the expression (*value & BIT(i)) causes undefined behavior due
> > to shifting by a value >= type width.
> >
> > Since 'value' is a pointer to u64, use BIT_ULL() to ensure correct
> > 64-bit mask on all architectures.
> >
> > Found by Linux Verification Center (linuxtesting.org) with Svace.
> >
> > Fixes: 2c4d00cb8fc5 ("gpiolib: acpi: Use BIT() macro to increase readability")
> > Signed-off-by: Denis Sergeev <denserg.edu@xxxxxxxxx>
>
> Reviewed-by: Mika Westerberg <westeri@xxxxxxxxxx>

I'll queue this for v6.19-rc8.

Bart