Re: [PATCH v5 5/6] i2c: xiic: switch to generic device property accessors

From: Andy Shevchenko

Date: Tue Jan 27 2026 - 04:45:49 EST


On Mon, Jan 26, 2026 at 05:08:20PM +0000, Abdurrahman Hussain via B4 Relay wrote:

> Use generic device property accessors.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

One nit-pick below.

...

> - ret = devm_request_threaded_irq(&pdev->dev, irq, NULL,
> - xiic_process, IRQF_ONESHOT,
> - pdev->name, i2c);
> + ret = devm_request_threaded_irq(dev, irq, NULL, xiic_process,
> + IRQF_ONESHOT, pdev->name, i2c);

>

Also drop this blank line.

> if (ret < 0)
> return ret;

--
With Best Regards,
Andy Shevchenko