Re: [PATCH v10 5/7] qcom-tgu: Add support to configure next action

[Konrad Dybcio]

On 1/27/26 3:43 AM, Songwei Chai wrote:
> 
> 
> On 1/13/2026 7:15 PM, Konrad Dybcio wrote:
>> On 1/9/26 3:11 AM, Songwei Chai wrote:
>>> Add "select" node for each step to determine if another step is taken,
>>> trigger(s) are generated, counters/timers incremented/decremented, etc.
>>>
>>> Signed-off-by: Songwei Chai <songwei.chai@xxxxxxxxxxxxxxxx>
>>> ---

[...]

>>> +    select = devm_kzalloc(dev, select_size, GFP_KERNEL);
>>> +
>>> +    if (!select)
>>
>> stray \n
> Will improve this based on the comments above.
>>
>>> +        return -ENOMEM;
>>> +
>>> +    drvdata->value_table->condition_select = select;
>>
>> I don't see a need for an intemediate variable here
> 
> This was done intentionally, following the earlier suggestion in v9 to
> introduce named intermediate variables for better readability when dealing with allocations.
> 
> I’m happy to inline the allocation if you prefer the simpler form here.

I don't mind that much

Konrad