Re: [PATCH] arm64: dts: qcom: talos: add ETR device

[Konrad Dybcio]

On 1/23/26 8:10 AM, Jie Gan wrote:
> Add the TMC ETR device to store collected trace data in DDR memory.
> 
> Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/talos.dtsi | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/talos.dtsi b/arch/arm64/boot/dts/qcom/talos.dtsi
> index 75716b4a58d6..3b081ce9d202 100644
> --- a/arch/arm64/boot/dts/qcom/talos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/talos.dtsi
> @@ -2253,6 +2253,14 @@ out-ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> +				port@0 {
> +					reg = <0>;
> +
> +					replicator0_out0: endpoint {
> +						remote-endpoint = <&tmc_etr_in>;
> +					};
> +				};
> +
>  				port@1 {
>  					reg = <1>;
>  
> @@ -2287,6 +2295,25 @@ tmc_etf_out: endpoint {
>  			};
>  		};
>  
> +		tmc_etr: tmc@6048000 {

This label is unused, please remove it

Otherwise lgtm

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad