Re: [PATCH] scripts: generate_rust_analyzer.py: avoid FD leak

[Tamir Duberstein]

On Sun, Jan 25, 2026 at 9:09 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Thu, Jan 22, 2026 at 5:44 PM Tamir Duberstein <tamird@xxxxxxxxxx> wrote:
> >
> > Use a context manager to avoid leaking file descriptors.
>
> This may have been intentionally written like that for simplicity,
> since I think CPython closes them immediately in practice even if it
> does not guarantee it (and I think the kernel may be assuming CPython
> given the version requirement?).

I'm not sure how CPython could close the FD immediately - it would
require the GC to run, at least? Anyway, agree with you below:

> Nevertheless, it is better to be explicit and proper, but it is not
> urgent, so I would say let's put this in rust-analyzer after the merge
> window even if you end up considering it a fix.

Works for me.

> Like in the other one, I don't see the Tested-by from Daniel, so I
> would suggest taking the chance to double-check that meanwhile too.

I think you're right. I'll strip that tag.

> Thanks!

Thanks for reviewing!