Re: [PATCH] spi: dw-mmio: support suspend/resume

[Mark Brown]

On Tue, Jan 27, 2026 at 05:01:54PM +0100, Andy Shevchenko wrote:
> On Thu, Jan 22, 2026 at 05:57:42PM +0000, Mark Brown wrote:

> > These were allocated using devm_clk_get_prepare_enable() so we shouldn't
> > really be fiddling with the state at runtime.  In practice this should
> > always be fine I think but it's not really something we're supposed to
> > be doing, in theory we could fail to resume and then end up doing a
> > double disable on removal.  Probably the open coded version would have
> > the same issue though so perhaps this is pedantic...

> We clearly can call clk_disable(), but I'm not sure unprepare is the stage that
> has no side-effects here.

What makes you say that disable is OK?

Attachment: signature.asc
Description: PGP signature