Re: [PATCH v2 2/3] gpio: brcmstb: implement irq_mask_ack

[Linus Walleij]

On Tue, Jan 27, 2026 at 10:47 PM Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:

> From: Doug Berger <opendmb@xxxxxxxxx>
>
> The irq_mask_ack operation is slightly more efficient than doing
> irq_mask and irq_ack separately.
>
> More importantly for this driver it bypasses the check of
> irqd_irq_masked ensuring a previously masked but still active
> interrupt gets remasked if unmasked at the hardware level. This
> allows the driver to more efficiently unmask the wake capable
> interrupts when quiescing without needing to enable the irqs
> individually to clear the irqd_irq_masked state.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
> Co-developed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij