回复：[PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs

[Illusion Wang]

Thank you for your feedback

patch3 primarily includes code that does not require extensive review,
such as the message codes and message body structures defined in
nbl_def_channel.h. These components are generally stable and
used for PF/VF communication, which is why they were initially
included in Patch 3. However, based on review feedback, I will
extract these manually written communication protocol definitions.

Additionally, I will make another round of comprehensive code
reduction to meet the submission requirements as much as possible.


------------------------------------------------------------------
发件人：Jakub Kicinski <kuba@xxxxxxxxxx>
发送时间：2026年1月28日(周三) 02:53
收件人：Simon Horman<horms@xxxxxxxxxx>; Illusion Wang<illusion.wang@xxxxxxxxxxxxxxxxx>
抄　送：Dimon<dimon.zhao@xxxxxxxxxxxxxxxxx>; Alvin<alvin.wang@xxxxxxxxxxxxxxxxx>; Sam<sam.chen@xxxxxxxxxxxxxxxxx>; netdev<netdev@xxxxxxxxxxxxxxx>; "andrew+netdev"<andrew+netdev@xxxxxxx>; corbet<corbet@xxxxxxx>; "linux-doc"<linux-doc@xxxxxxxxxxxxxxx>; lorenzo<lorenzo@xxxxxxxxxx>; pabeni<pabeni@xxxxxxxxxx>; "vadim.fedorenko"<vadim.fedorenko@xxxxxxxxx>; "lukas.bulwahn"<lukas.bulwahn@xxxxxxxxxx>; hawk<hawk@xxxxxxxxxx>; ast<ast@xxxxxxxxxx>; bpf<bpf@xxxxxxxxxxxxxxx>; sdf<sdf@xxxxxxxxxxx>; daniel<daniel@xxxxxxxxxxxxx>; "john.fastabend"<john.fastabend@xxxxxxxxx>; edumazet<edumazet@xxxxxxxxxx>; open list<linux-kernel@xxxxxxxxxxxxxxx>
主　题：Re: [PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs


On Tue, 27 Jan 2026 18:06:49 +0000 Simon Horman wrote:
> As per Jakub's advice in his review of v1 [*],
> Please try to create a minimal driver in the order of ~5kLoC.

Perhaps other maintainers will disagree, but for ease of review
and to avoid the huge reposts perhaps we should consider merging
something like patches 1 and 3* first, as the initial series.
And then you can build up the driver from there in reasonable,
5kLoC-at-a-time series?

 * patch 3 currently includes things which do not seem machine
   generated / like register descriptors like structs added to
   nbl_def_channel.h and nbl_include.h