Re: [PATCH FOR REFERENCE v4 7/7] gpu: nova-core: use the kernel `register!` macro

[John Hubbard]

On 1/27/26 6:37 PM, Alexandre Courbot wrote:
> Replace the nova-core internal `register!` macro by the one defined in
> the `kernel` crate and remove our own private implementations.
> 
> Tested-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
>  drivers/gpu/nova-core/falcon.rs           | 175 +++----
>  drivers/gpu/nova-core/falcon/gsp.rs       |  12 +-
>  drivers/gpu/nova-core/falcon/hal/ga102.rs |  15 +-
>  drivers/gpu/nova-core/falcon/sec2.rs      |  13 +-
>  drivers/gpu/nova-core/fb/hal/ga100.rs     |  17 +-
>  drivers/gpu/nova-core/fb/hal/tu102.rs     |   2 +-
>  drivers/gpu/nova-core/gpu.rs              |  31 +-
>  drivers/gpu/nova-core/gsp/cmdq.rs         |   4 +-
>  drivers/gpu/nova-core/regs.rs             | 494 +++++++++++---------
>  drivers/gpu/nova-core/regs/macros.rs      | 739 ------------------------------
>  10 files changed, 397 insertions(+), 1105 deletions(-)

Reading through this, it does look like an across the board improvement
in readability in nova-core. Great!

thanks,
-- 
John Hubbard