RE: [PATCH] iio: adc: vf610: Add missing check for device_property_read_u32_array

[Bough Chen]

> -----Original Message-----
> From: Chen Ni <nichen@xxxxxxxxxxx>
> Sent: 2026年1月28日 12:27
> To: Bough Chen <haibo.chen@xxxxxxx>; jic23@xxxxxxxxxx;
> dlechner@xxxxxxxxxxxx; nuno.sa@xxxxxxxxxx; andy@xxxxxxxxxx
> Cc: linux-iio@xxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> Chen Ni <nichen@xxxxxxxxxxx>
> Subject: [PATCH] iio: adc: vf610: Add missing check for
> device_property_read_u32_array
> 
> Add check for the return value of device_property_read_u32_array() and return
> the error if it fails in order to catch the error.

Reviewed-by: Haibo Chen <haibo.chen@xxxxxxx>

Best Regards
Haibo Chen
> 
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> ---
>  drivers/iio/adc/vf610_adc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c index
> d7182ed0d2a7..d53723ccc5b2 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -871,7 +871,10 @@ static int vf610_adc_probe(struct platform_device
> *pdev)
> 
>  	info->vref_uv = regulator_get_voltage(info->vref);
> 
> -	device_property_read_u32_array(dev, "fsl,adck-max-frequency",
> info->max_adck_rate, 3);
> +	ret = device_property_read_u32_array(dev, "fsl,adck-max-frequency",
> +					     info->max_adck_rate, 3);
> +	if (ret)
> +		return ret;
> 
>  	info->adc_feature.default_sample_time = DEFAULT_SAMPLE_TIME;
>  	device_property_read_u32(dev, "min-sample-time",
> &info->adc_feature.default_sample_time);
> --
> 2.25.1