Re: [PATCH] pinctrl: equilibrium: Fix device node reference leak in pinbank_init()

From: Linus Walleij

Date: Wed Jan 28 2026 - 02:57:40 EST


On Mon, Jan 26, 2026 at 6:30 PM Felix Gu <ustc.gu@xxxxxxxxx> wrote:

> When calling of_parse_phandle_with_fixed_args(), the caller is
> responsible to call of_node_put() to release the reference of device
> node.
>
> In pinbank_init(), the reference of the node obtained from the
> "gpio-ranges" property is never released, resulting in a reference
> count leak.
>
> Add the missing of_node_put() call to fix the leak.
>
> Fixes: 1948d5c51dba ("pinctrl: Add pinmux & GPIO controller driver for a new SoC")
> Signed-off-by: Felix Gu <ustc.gu@xxxxxxxxx>

Patch applied!

Yours,
Linus Walleij