Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"

From: Janne Grunau

Date: Wed Jan 28 2026 - 03:30:11 EST


On Mon, Jan 26, 2026 at 04:52:06PM +0100, Thomas Gleixner wrote:
> On Sun, Jan 25 2026 at 12:08, Janne Grunau wrote:
> > +/*
> > + * AIC v3 registers (MMIO)
> > + */
> > +
>
> Pointless newline and please make this a /* Oneline comment */

copy-n-pasted from AICv2 (and AICv1) above, changed locally for v2

> > +#define AIC3_IRQ_CFG 0x10000
> > +
> > }
> > + case 3:
> > case 2: {
>
> 1 3 2 is a weird count order...

version 3 was using a fall-through in the intial version so the order
made sense then. Change locally to 'case 2 ... 3:'

Janne