Re: [PATCH v1 3/3] pinctrl: core: Remove duplicate error messages

[Bartosz Golaszewski]

On Tue, 27 Jan 2026 11:32:08 +0100, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> said:
> pinctrl_claim_hogs() is covered to report any error via message.
> Since that it's not needed in the callers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  drivers/pinctrl/core.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> index ebf803bff867..342bda2a1bd6 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -2187,10 +2187,8 @@ int pinctrl_enable(struct pinctrl_dev *pctldev)
>  	int error;
>
>  	error = pinctrl_claim_hogs(pctldev);
> -	if (error) {
> -		dev_err(pctldev->dev, "could not claim hogs: %i\n", error);
> +	if (error)
>  		return error;
> -	}
>
>  	mutex_lock(&pinctrldev_list_mutex);
>  	list_add_tail(&pctldev->node, &pinctrldev_list);
> --
> 2.50.1
>
>

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxxxxxxxx>