Re: [PATCH net-next V6 07/14] devlink: Add parent dev to devlink API

From: Simon Horman

Date: Wed Jan 28 2026 - 04:21:22 EST


On Tue, Jan 27, 2026 at 02:25:51PM +0000, Cosmin Ratiu wrote:
> On Tue, 2026-01-27 at 13:49 +0000, Simon Horman wrote:
> > On Sun, Jan 25, 2026 at 01:31:56PM +0200, Tariq Toukan wrote:
> > > From: Cosmin Ratiu <cratiu@xxxxxxxxxx>

...

Hi Cosmin,

> Hi Simon,
>
> We had this conversation during v4, I replied then [1].

Sorry, I had forgotten about that.

> But thinking about it a bit more, I think it's indeed slightly cleaner
> to move the policy and the new pre/post doit handlers to the next
> patch, where they are actually used. The only bit is that the policy is
> used from devlink_get_parent_from_attrs_lock from this function, but it
> appears safe to use NULL there until next patch (the underlying parse
> functions tolerate NULL policies).
>
> So I'll do that in the next submission.

Thanks, that makes sense.
And I'll try to remember this conversation when looking at the next version :)

>
> [1]
> https://lore.kernel.org/netdev/3ec956ea1d0a1c6e56865b2ded6d83ed773ccd4d.camel@xxxxxxxxxx/