Re: [PATCH net-next v4 1/8] net: dsa: microchip: Add support for KSZ8463 global irq

[Bastien Curutchet]

Hi Jakub,

On 1/28/26 4:03 AM, Jakub Kicinski wrote:
> On Tue, 27 Jan 2026 10:06:43 +0100 Bastien Curutchet (Schneider
> Electric) wrote:
> >   	/* Read interrupt status register */
> > -	ret = ksz_read8(dev, kirq->reg_status, &data);
> > +	ret = ksz_read16(dev, kirq->reg_status, &data);
>
> AI code review points out that we're potentially over-reading here for
> !ksz_is_ksz8463(kirq->dev), I'm assuming the wider read is okay for all
> chips? Is this something that'll be obvious to all readers of this code
> or should we perhaps leave a relevant comment here? (assuming you need
> to respin, not sure its worth a respin by itself)

The loop below this read only iterates over the first kirq->nirqs bits, 
so I assume a wider read is fine. I wanted to avoid adding if 
(ksz_is_ksz8463()) branches as much as possible.

Indeed, a comment wouldn't hurt here; I'll add one if I need to respin.


Best regards,
Bastien