Re: [PATCH 1/5] drm/bridge: dw-hdmi-qp: Provide HDMI Vendor Specific InfoFrame

[Daniel Stone]

Hi Cristian,

On Sun, 25 Jan 2026 at 00:23, Cristian Ciocaltea
<cristian.ciocaltea@xxxxxxxxxxxxx> wrote:
> +       /* VSI packet body */
> +       for (i = 0; i < len - 3; i += 4)
> +               dw_hdmi_qp_write_pkt(hdmi, buffer + 3, i, min(len - i - 3, 4),
> +                                    PKT_VSI_CONTENTS1 + i);

Given that this for loop occurs in all the users (other than when len
< 4 where it's not required), why not move it into the
dw_hdmi_qp_write_pkt() helper itself, such that the calls for each
infoframe could be dw_hdmi_qp_write_pkt(hdmi, buffer + 3, len,
PKT_VSI_CONTENTS1 /* base reg, incremented by helper */)?

Cheers,
Daniel