Re: [PATCH v2 15/20] mfd: wm8350-core: Use IRQF_ONESHOT
From: Andy Shevchenko
Date: Wed Jan 28 2026 - 08:09:52 EST
On Wed, Jan 28, 2026 at 10:55:35AM +0100, Sebastian Andrzej Siewior wrote:
> Using a threaded interrupt without a dedicated primary handler mandates
> the IRQF_ONESHOT flag to mask the interrupt source while the threaded
> handler is active. Otherwise the interrupt can fire again before the
> threaded handler had a chance to run.
>
> Mark explained that this should not happen with this hardware since it
> is a slow irqchip which is behind an I2C/ SPI bus but the IRQ-core will
> refuse to accept such a handler.
>
> Set IRQF_ONESHOT so the interrupt source is masked until the secondary
> handler is done.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko