Re: [PATCH v2 1/7] serial: 8250: Protect LCR write in shutdown
From: Andy Shevchenko
Date: Wed Jan 28 2026 - 08:12:41 EST
On Wed, Jan 28, 2026 at 12:52:55PM +0200, Ilpo Järvinen wrote:
> The 8250_dw driver needs to potentially perform very complex operations
> during LCR writes because its BUSY handling prevents updates to LCR
> while UART is BUSY (which is not fully under our control without those
> complex operations). Thus, LCR writes should occur under port's lock.
>
> Move LCR write under port's lock in serial8250_do_shutdown(). Also
> split the LCR RMW so that the logic is on a separate line for clarity.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko