Re: [PATCH v2 0/4] staging: rtl8723bs: remove unused diagnostic
From: Dan Carpenter
Date: Wed Jan 28 2026 - 08:25:29 EST
On Tue, Jan 27, 2026 at 06:40:04PM -0600, Ethan Tidmore wrote:
> This series performs a driver-wide audit and cleanup of dead diagnostic
> code within the rtl8723bs staging driver.
>
> The vendor-originated code included a variety of diagnostic counters
> housed within 'struct debug_priv'. These counters were updated
> throughout the driver's hot paths—including MLME, receive, power
> control, and SDIO allocation—but were never read, exposed via
> debugfs, or utilized for any internal logic.
>
> This series removes the write-only counters, the skeletal functions
> used to update them, and cleans up the resulting unused pointers
> and logic blocks.
>
> Changes in v2:
> - Expanded the series to include the removal of RX FIFO overflow
> logic in hal_com.c.
>
Please don't send multiple versions of a patch on the same day.
Anyway, kbuild bot complained so at least I don't have to review this
now.
regards,
dan carpenter