Re: [PATCH] iio: sca3000: Fix a resource leak in sca3000_probe()

[Harshit Mogalapalli]

Hi Andy,

On 28/01/26 15:18, Andy Shevchenko wrote:
> On Tue, Jan 27, 2026 at 10:49:49PM -0800, Harshit Mogalapalli wrote:
> > spi->irq from request_threaded_irq() not released when
> > iio_device_register() fails. Add an return value check and jump to a
> > common error handler when iio_device_register() fails.
>
> LGTM, but I would rather converting this to use managed resources.

Thanks for the review.

I’ll follow up with a separate patch that converts it to devm-based
resource handling. Maybe that helps in a way to keep the fix and
refactor separate ?

> So, if Jonathan wants to take this first,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

Thanks!

Regards,
Harshit