Re: [PATCH v1 1/1] serial: 8250_port: Drop duplicate NULL check

From: Andy Shevchenko

Date: Wed Jan 28 2026 - 10:48:52 EST


On Wed, Jan 28, 2026 at 05:09:31PM +0200, Ilpo Järvinen wrote:
> On Wed, 28 Jan 2026, Andy Shevchenko wrote:

...

> > - if (up->dma)
> > - serial8250_release_dma(up);
> > + serial8250_release_dma(up);
> > + up->dma = NULL;
>
> Seems reasonable safeguard,

Note, 8250_omap does the same for last 3 years.

> Reviewed-by: Ilpo J�inen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Thanks!


--
With Best Regards,
Andy Shevchenko