Re: [PATCH net v4 0/3] net: liquidio: Fix memory leaks in setup_nic_devices()
From: Kory Maincent
Date: Wed Jan 28 2026 - 11:05:43 EST
On Wed, 28 Jan 2026 15:44:37 +0000
Zilin Guan <zilin@xxxxxxxxxx> wrote:
> This series fixes memory leaks in the initialization paths of the
> NIC devices.
>
> Patch 1 moves the initialization of oct->props[i].netdev before queue
> setup calls. This ensures that if queue setup fails, the cleanup function
> can find and free the allocated netdev. It also initializes lio->oct_dev
> early to prevent a crash in the cleanup path.
>
> Patch 2 fixes an off-by-one error in the PF cleanup loop. It ensures
> the current device index is cleaned up and correctly handles the
> post-loop devlink_alloc failure case.
>
> Patch 3 fixes the same off-by-one error in the VF cleanup loop.
For the series:
Reviewed-by: Kory Maincent <kory.maincent@xxxxxxxxxxx>
Thank you!
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com