Re: [PATCH] staging: rtl8723bs: constify _action_public_str array

[Ethan Tidmore]

On Wed, Jan 28, 2026 at 5:39 AM, Tanjim Kamal <tanjimkamal1@xxxxxxxxx> wrote:
> This array is never modified. Add a second const to make the array
> itself be placed in read-only .rodata instead of just the strings it
> points to.
>
> Fix a WARNING issued by scripts/checkpatch.pl.
>
> Signed-off-by: Tanjim Kamal <tanjimkamal1@xxxxxxxxx>

Reviewed-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>

On Wed, Jan 28, 2026 at 5:39 AM Tanjim Kamal <tanjimkamal1@xxxxxxxxx> wrote:
>
> This array is never modified. Add a second const to make the array
> itself be placed in read-only .rodata instead of just the strings it
> points to.
>
> Fix a WARNING issued by scripts/checkpatch.pl.
>
> Signed-off-by: Tanjim Kamal <tanjimkamal1@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 92b12a13d..febc14de6 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -1139,7 +1139,7 @@ int rtw_action_frame_parse(const u8 *frame, u32 frame_len, u8 *category, u8 *act
>         return true;
>  }
>
> -static const char *_action_public_str[] = {
> +static const char * const _action_public_str[] = {
>         "ACT_PUB_BSSCOEXIST",
>         "ACT_PUB_DSE_ENABLE",
>         "ACT_PUB_DSE_DEENABLE",
> --
> 2.47.3
>