Re: [PATCH v3 1/4] staging: rtl8723bs: replace _rtw_malloc with kmalloc

[Andy Shevchenko]

On Wed, Jan 28, 2026 at 11:51:48PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 28, 2026 at 11:09:51PM +0900, Minu Jin wrote:

...

> > static void update_BCNTIM(struct adapter *padapter)
> 
> >  	if (remainder_ielen > 0) {
> > -		pbackup_remainder_ie = rtw_malloc(remainder_ielen);
> > +		pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_ATOMIC);
> >  		if (pbackup_remainder_ie && premainder_ie)
> >  			memcpy(pbackup_remainder_ie, premainder_ie, remainder_ielen);
> 
> I haven't read the code in full, but why not
> 
> 		if (premainder_ie)
> 			pbackup_remainder_ie = kmemdup(rpremainder_ie, emainder_ielen, GFP_ATOMIC);

This was typed with typos, should be

			pbackup_remainder_ie = kmemdup(remainder_ie, remainder_ielen, GFP_ATOMIC);

> 		else
> 			pbackup_remainder_ie = kmalloc(remainder_ielen, GFP_ATOMIC);
> 
> >  	}

-- 
With Best Regards,
Andy Shevchenko