Re: [RFC PATCH 40/77] dtc: Introduce dti_get_node_by_path()
From: David Gibson
Date: Wed Jan 28 2026 - 21:04:24 EST
On Mon, Jan 19, 2026 at 04:52:44PM +0100, Herve Codina wrote:
> Hi David,
>
> On Thu, 15 Jan 2026 17:47:29 +1100
> David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Mon, Jan 12, 2026 at 03:19:30PM +0100, Herve Codina wrote:
> > > The future introduction of orphan nodes for addons device-tree will lead
> > > to more than one tree in the addons data. Those trees will be:
> > > - the classical root tree starting at the root node
> > > - trees related to orphan nodes
> >
> > This doesn't make sense to me. The new function still just takes a
> > single path, nothing to specify which tree that path is looked up in.
> >
> > You can probably guarantee that labels and phandles are unique across
> > all the trees. Not paths, though.
> >
>
> Paths can be unique across all trees. The tree needs to be indicated in the
> path. Starting by '/' is the root tree.
Oh, ok. That wasn't clear from this patch, and I must have missed it
in my cursory look at the later patches. I had the mistaken
impression this just looked for the same path in each orphan tree.
> For orphans, I proposed "$<orphan_name>/<path>" in patch 64 introducing
> references by path for orphan nodes and so, for orphan trees.
>
> Best regards,
> Hervé
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature