Re: [PATCH] drivers: pwm: remove redundant check in pwm_ops_check()

[Uwe Kleine-König]

Hello Ben,

thanks for your patch.

On Thu, Jan 29, 2026 at 02:43:34PM +0800, Ben Zong-You Xie via B4 Relay wrote:
> From: Ben Zong-You Xie <ben717@xxxxxxxxxxxxx>
> 
> Drop the redundant check for the existence of 'ops->write_waveform'.
> 
> Fixes: 17e40c25158f ("pwm: New abstraction for PWM waveforms")
> Signed-off-by: Ben Zong-You Xie <ben717@xxxxxxxxxxxxx>

I would rewrite the commit log to:

	pwm: Remove redundant check in pwm_ops_check()

	ops->write_waveform is already known to be non-NULL so there is
	no need to check it a second time.

	The superflous check was introduced in commit 17e40c25158f
	("pwm: New abstraction for PWM waveforms").

	Signed-off-by: Ben Zong-You Xie <ben717@xxxxxxxxxxxxx>

to make the change more clear and also to not bother the stable team
with backporting the commit to stable.

Please confirm if you're ok with this change, then I cope for the update
while applying your change.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature