Re: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with proper errno
From: Dan Carpenter
Date: Thu Jan 29 2026 - 02:28:41 EST
On Wed, Jan 28, 2026 at 06:21:43PM +0100, Omer El Idrissi wrote:
> Changes since v1:
> - Removed leftover comment accidentally left in previous version
> - No functional changes
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@xxxxxxxxx>
No commit message.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Why is do you change -2 to both -EBUSY and -ENOBUFS? In the original
code, the -1 and -2 return meant something custom and they weren't
kernel error codes:
* Return:
*0 Success
*-1 Hardware resource(TX FIFO) not ready
*-2 Software resource(xmitbuf) not ready
Now the documentation makes no sense.
regards,
dan carpenter