Re: [PATCH v2 09/12] mm, swap: use the swap table to track the swap count

From: YoungJun Park

Date: Thu Jan 29 2026 - 03:33:36 EST


On Wed, Jan 28, 2026 at 05:28:33PM +0800, Kairui Song wrote:
> From: Kairui Song <kasong@xxxxxxxxxxx>

> index bfafa637c458..751430e2d2a5 100644
> --- a/mm/swap.h
> +++ b/mm/swap.h
> @@ -37,6 +37,7 @@ struct swap_cluster_info {
> u8 flags;
> u8 order;
> atomic_long_t __rcu *table; /* Swap table entries, see mm/swap_table.h */
> + unsigned long *extend_table; /* For large swap count, protected by ci->lock */

I assume using 'int *' is to save memory on 64-bit architectures (8 bytes ->
4 bytes per entry), which aligns with swp_tb_get_count() returning an int.

Regarding the extended reference table.
While I agree that a simple array is better for speed, readability and so on, the
2KB overhead (assuming SWAPFILE_CLUSTER=256) might be significant in
constrained environments when only a few entries overflow SWP_TB_COUNT_MAX.

Have you considered using a resizable hash table(example. or something others)
instead? I am curious if this approach could be applicable
as a future optimization after the current code is merged.

Thanks :)
Youngjun Park