Re: [RFC PATCH] net: phy: integrate reset-after-clock quirk into phy_init_hw

[Marco Felsch]

On 26-01-29, Russell King (Oracle) wrote:
> On Thu, Jan 29, 2026 at 11:41:23AM +0100, Marco Felsch wrote:
> > As said, I don't see a problem with the LAN8710. But while checking the
> > Linux source code, I saw commit
> > 57ec5a8735dc5dccd1ee68afdb1114956a3fce0d which re-introduced the reset
> > handling :-/
> 
> So now we get to the bottom of it. This is a regression, right? The
> addition of that patch has caused previously working boards to stop
> working, correct?

The commit is part of 6.17 and the system I've added the support for the
clk handling is currently running on 6.14. I have to ask a colleague of
mine to very this.

But yes, it seems like a regression.

> That means it needs to be reverted.

Yes.

> We also need to get out of our heads the idea that LAN8710A is somehow
> special in needing this. It isn't. Thus, there should be no special
> flags to "work around" this "problem".

IMHO this flag should be removed completely because it makes the
phy-driver mac-driver dependent. Since the FEC is the only driver
checking this flag.

Regards,
  Marco

> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
> 

-- 
#gernperDu 
#CallMeByMyFirstName

Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |