Re: [net-next v8 3/8] net: wwan: core: split port creation and registration
From: Paolo Abeni
Date: Thu Jan 29 2026 - 06:46:59 EST
On 1/26/26 7:21 AM, Slark Xiao wrote:
> From: Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx>
>
> Upcoming GNSS (NMEA) port type support requires exporting it via the
> GNSS subsystem. On another hand, we still need to do basic WWAN core
> work: find or allocate the WWAN device, make it the port parent, etc. To
> reuse as much code as possible, split the port creation function into
> the registration of a regular WWAN port device, and basic port struct
> initialization.
>
> To be able to use put_device() uniformly, break the device_register()
> call into device_initialize() and device_add() and call device
> initialization earlier.
>
> While at it, fix a minor number leak upon WWAN port registration
> failure.
>
> Signed-off-by: Sergey Ryazanov <ryazanov.s.a@xxxxxxxxx>
The series LGTM, but waiting a bit more for Loic's explicit ack here.
Thanks,
Paolo