RE: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field

[Miclaus, Antoniu]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Sent: Thursday, January 29, 2026 4:28 PM
> To: Miclaus, Antoniu <Antoniu.Miclaus@xxxxxxxxxx>
> Cc: Lars-Peter Clausen <lars@xxxxxxxxxx>; Hennerich, Michael
> <Michael.Hennerich@xxxxxxxxxx>; Jonathan Cameron <jic23@xxxxxxxxxx>;
> David Lechner <dlechner@xxxxxxxxxxxx>; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>;
> Andy Shevchenko <andy@xxxxxxxxxx>; Gradinariu, Ramona
> <Ramona.Gradinariu@xxxxxxxxxx>; Andrew Ijano
> <andrew.ijano@xxxxxxxxx>; Gustavo Bastos <gustavobastos@xxxxxx>; linux-
> iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/3] iio: accel: adxl372: remove unused int2_bitmask field
> 
> [External]
> 
> On Thu, Jan 29, 2026 at 04:11:57PM +0200, Antoniu Miclaus wrote:
> > Remove unused int2_bitmask field from adxl372_state struct.
> > The field is declared but never accessed in the driver.
> 
> While patches are okay, you have two issues with the series (or three):
> - the email thread is not a thread, missed --thread?

Thanks for pointing that out. I never used --thread before, is the first time I am 
seeing it mentioned in a review.

> - the series lacks of a cover letter

True. Will do that in v2 (if changes requested). Btw, for these small changes if they
aren't placed in a series but individually I guess I can skip the cover letter?

> You can use my script [1] to make it not forgotten.
> 
> [1]: https://urldefense.com/v3/__https://github.com/andy-shev/home-bin-
> tools/blob/master/ge2maintainer.sh__;!!A3Ni8CS0y2Y!48H-
> JjuYcJZ2OfRfcWweVwMeYt0ghmCKzi1zlIX6jeIA15T0zhb28_T2Zj1YrAL8ho-
> gPXrtsmWhbYh4wW8N1TrsINiFNkI$
> 
> P.S. I hope that this simple thing can be caught during internal reviews...
> 
> --
> With Best Regards,
> Andy Shevchenko
>