Re: [PATCH] rpmsg: glink: Replace strcpy() with strscpy()

[Chris Lew]

On Thu, Dec 11, 2025 at 02:18:34PM +0530, Vishnu Santhosh wrote:
> From: Sudeepgoud Patil <quic_sudeepgo@xxxxxxxxxxx>
> 
> Replace strcpy() with the safer strscpy() to address unsafe API
> usage warnings[1] from static analysis tools, as strcpy() performs
> no bounds checking on the destination buffer.
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy
> 
> Signed-off-by: Sudeepgoud Patil <quic_sudeepgo@xxxxxxxxxxx>
> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
> ---
>  drivers/rpmsg/qcom_glink_native.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Chris Lew <christopher.lew@xxxxxxxxxxxxxxxx>

> diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
> index 5ea096acc8581b1aff106f4c0e2f9aee9d56e25b..37b2255495d53270521466a05a5eb97eca98ec0e 100644
> --- a/drivers/rpmsg/qcom_glink_native.c
> +++ b/drivers/rpmsg/qcom_glink_native.c
> @@ -501,7 +501,7 @@ static int qcom_glink_send_open_req(struct qcom_glink *glink,
>  	req->cmd = cpu_to_le16(GLINK_CMD_OPEN);
>  	req->param1 = cpu_to_le16(channel->lcid);
>  	req->param2 = cpu_to_le32(name_len);
> -	strcpy(req->data, channel->name);
> +	strscpy(req->data, channel->name, GLINK_NAME_SIZE);
>  
>  	trace_qcom_glink_cmd_open_tx(glink->label, channel->name,
>  				     channel->lcid, channel->rcid);
> 
> ---
> base-commit: d358e5254674b70f34c847715ca509e46eb81e6f
> change-id: 20251203-rpmsg-glink-strcpy-replace-738ab624071f
> 
> Best regards,
> -- 
> Vishnu Santhosh <vishnu.santhosh@xxxxxxxxxxxxxxxx>
>