Re: [PATCH v2] function_graph: Fix args pointer mismatch in print_graph_retval()

[Donglin Peng]

On Sat, Jan 24, 2026 at 1:18 AM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> On Mon, 12 Jan 2026 10:16:01 +0800
> Donglin Peng <dolinux.peng@xxxxxxxxx> wrote:
>
> > From: Donglin Peng <pengdonglin@xxxxxxxxxx>
> >
> > When funcgraph-args and funcgraph-retaddr are both enabled, many kernel
> > functions display invalid parameters in trace logs[1].
> >
> > The issue occurs because print_graph_retval() passes a mismatched args
> > pointer to print_function_args(). Fix this by retrieving the correct
> > args pointer using the FGRAPH_ENTRY_ARGS() macro.
> >
> > [1] https://gitee.com/pengdonglin137/funcgraph_visualization/raw/master/samples/error_args.png
>
> Please do not provide links to images. This stays in the git logs for the
> lifetime of the Linux kernel. Images like this will likely not live as long
> and the link becomes wasted space in the git history.

Thanks for pointing this out.

>
> Either do a cut and paste of the bad output, or don't include it at all.

Thanks.

>
> -- Steve
>
>
> > Fixes: f83ac7544fbf ("function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously")
> > Signed-off-by: Donglin Peng <pengdonglin@xxxxxxxxxx>