Re: [PATCH v2 1/8] thermal: Add Remote Proc cooling driver
From: Gaurav Kohli
Date: Fri Jan 30 2026 - 01:42:57 EST
On 1/28/2026 5:06 PM, Krzysztof Kozlowski wrote:
On Tue, Jan 27, 2026 at 09:27:15PM +0530, Gaurav Kohli wrote:
+ if (!name || !ops)Ah, you keep ignoring review and sending the same buggy code.
+ return ERR_PTR(-EINVAL);
+
+ rproc_cdev = kzalloc(sizeof(*rproc_cdev), GFP_KERNEL);
+ if (!rproc_cdev)
+ return ERR_PTR(-ENOMEM);
+
+ rproc_cdev->ops = ops;
+ rproc_cdev->devdata = devdata;
+ mutex_init(&rproc_cdev->lock);
+
+ char *rproc_name __free(kfree) =
+ kasprintf(GFP_KERNEL, REMOTEPROC_PREFIX "%s", name);
There is no point to spend any time here. It's also fastest way to get
your future contributions ignored or NAKed.
Apologies for the miss, will make sure not to miss this in future version.
Well, ignoring review is obviously:
NAK
Best regards,
Krzysztof