Re: [PATCH v5 11/31] clk: at91: clk-usb: add support for clk_parent_data

[claudiu beznea]

Hi, Ryan,

On 1/16/26 22:07, ryan.wanner@xxxxxxxxxxxxx wrote:
> @@ -818,18 +817,22 @@ static void __init sam9x7_pmc_setup(struct device_node *np)
>   				switch (sam9x7_plls[i][j].p) {
>   				case SAM9X7_PLL_PARENT_MAINCK:
>   					parent_data[0] = AT91_CLK_PD_NAME("mainck");
> -					hw = sam9x7_pmc->chws[PMC_MAIN];
> +					parent_rate = clk_hw_get_rate(sam9x7_pmc->chws[PMC_MAIN]);
>   					break;
>   				case SAM9X7_PLL_PARENT_MAIN_XTAL:
> +					struct clk *main_xtal;
> +					main_xtal = of_clk_get_by_name(np, main_xtal_name);
> +					if (IS_ERR(main_xtal))
> +						goto err_free;
>   					parent_data[0] = AT91_CLK_PD_NAME(main_xtal_name);
> -					hw = main_xtal_hw;
> +					parent_rate = clk_get_rate(main_xtal);
> +					clk_put(main_xtal);
>   					break;

Could you please let me know why is this change related to USB? It looks to me 
that it should go in a different patch. Same for the similar changes done on 
sama7d65.c. Sorry for not noticing it previously.

The rest LGTM.

Thank you,
Claudiu