Re: [PATCH v9 2/4] irqchip/irq-loongson.h:irq-loongson.h preparation for Redirect irqchip
From: Thomas Gleixner
Date: Fri Jan 30 2026 - 03:14:30 EST
On Fri, Jan 30 2026 at 10:59, Tianyang Zhang wrote:
The subject line is broken and incomprehensible. Something like:
irqchip/irq-loonarch-avec: Prepare for interrupt redirection support
is concise and gives context.
> Adjusted definitions and macro from loongson-avec.c to irq-loongson.h,
> including:
> 1 marco AVEC_MSG_OFFSET
> 2 struct avecintc_data
> 3 Make avecintc_sync public
That's not a change log because it only tells _what_ the patch is doing,
but not _why_. Enumerating the details of what is moved is a pointless
exercise because that can bee seen from the diff itself.
So you want something like:
Interrupt redirection support requires a new interrupt chip, which
needs to share data structures, constants and functions with the AVEC
code.
Move them to the header file and make the required functions public.
See?