Re: [PATCH v9 3/4] irqchip/loongarch-avec.c:return IRQ_SET_MASK_OK_DONE when keep affinity

[Thomas Gleixner]

On Fri, Jan 30 2026 at 10:59, Tianyang Zhang wrote:

  irqchip/irq-loonarch-avec: Return IRQ_SET_MASK_OK_DONE when affinity is unchanged

Note the space between 'prefix: ' and the shortlog sentence

> When it is detected in avecintc_set_affinity that the current affinity

Functions are denoted with fname() to make it clear. See

https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-submission-notes

> remains valid, the return value is modified to IRQ_SET_MASK_OK_DONE.

That's the very wrong order of explaining the change. You again explain
the _what_ first without giving context and reason.

See the above link. It provides guidance about structuring a change log.

> After the introduction of redirect-domain, for each interrupt source,
> avecintc-domain only provides the CPU/interrupt vector, while redirect-domain
> provides other operations to synchronize interrupt affinity information
> among multiple cores. The original intention is to notify the cascaded
> redirect_set_affinity that multi-core synchronization is not required.

"After the introduction.." is confusing at best.

> However, this introduces some compatibility issues, such as the new return
> value causing msi_domain_set_affinity to no longer perform irq_chip_write_msi_msg.
>   1) When redirect exist in the system, the msi msg_address and msg_data no
> longer changes after the allocation phase, so it does not actually require updating
> the MSI message info.
>   2) When only avecintc exists in the system, the irq_domain_activate_irq
> interface will be responsible for the initial configuration of the MSI message,
> which is unconditional. After that, if unnecessary, no modification to the MSI
> message is alse correctly.

Spell checkers exist for a reason.

Thanks

        tglx