Re: [PATCH net-next v2 00/12] net: phy_port: SFP modules representation and phy_port listing

From: Maxime Chevallier

Date: Fri Jan 30 2026 - 03:22:17 EST


Hi Jakub,

On 30/01/2026 04:59, Jakub Kicinski wrote:
> On Wed, 28 Jan 2026 21:45:13 +0100 Maxime Chevallier wrote:
>> Here's V2 of the second phy_port series, this time bringing support for
>> more phy_port use especially for SFP, as well as the beggining of a
>> ethnl uAPI. That's a quick repost, but with the build issues and AI
>> review, I think it's worth getting this version out there for review.
>>
>> It builds on the recent addition of phy_port representation to enable
>> listing the front-facing ports of an interface. For now, we don't control
>> these ports, we merely list their presence and their capabilities.
>>
>> As the most common use-case of multi-port interfaces is combo-ports that
>> provide both RJ45 and SFP connectors on a single MAC, there's a lot of
>> SFP stuff in this series.
>>
>> This series is in 2 main parts. The first one aims at representing the
>> SFP cages and modules using phy_port, as combo-ports with RJ45 + SFP are
>> by far the most common cases for multi-connector setups.
>>
>> The second part is the netlink interface to list those ports, now that
>> most use-cases are covered.
>
> I'll send out the AI code review. The one on patch 9 looks plausible,
> not sure about the rest. LMK if none of them in fact make sense.

Thanks, I'll look carefully into that :)

Maxime